Skip to content

Correct tables used for lookup in cert-based auth#35342

Merged
cdcme merged 3 commits intofeat-32247-ios-ipados-self-servicefrom
fix-32247-update-table-used-for-cert-based-auth
Nov 7, 2025
Merged

Correct tables used for lookup in cert-based auth#35342
cdcme merged 3 commits intofeat-32247-ios-ipados-self-servicefrom
fix-32247-update-table-used-for-cert-based-auth

Conversation

@cdcme
Copy link
Copy Markdown
Member

@cdcme cdcme commented Nov 7, 2025

Fixes cert-based auth to do device lookup using the correct tables

@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 69.69697% with 10 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (feat-32247-ios-ipados-self-service@7f22271). Learn more about missing BASE report.

Files with missing lines Patch % Lines
server/datastore/mysql/host_identity_scep.go 67.74% 8 Missing and 2 partials ⚠️
Additional details and impacted files
@@                          Coverage Diff                          @@
##             feat-32247-ios-ipados-self-service   #35342   +/-   ##
=====================================================================
  Coverage                                      ?   66.15%           
=====================================================================
  Files                                         ?     2075           
  Lines                                         ?   174918           
  Branches                                      ?     7173           
=====================================================================
  Hits                                          ?   115714           
  Misses                                        ?    48581           
  Partials                                      ?    10623           
Flag Coverage Δ
backend 67.79% <69.69%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cdcme cdcme marked this pull request as ready for review November 7, 2025 15:36
@cdcme cdcme requested a review from a team as a code owner November 7, 2025 15:36
@cdcme cdcme merged commit 2c9d1a0 into feat-32247-ios-ipados-self-service Nov 7, 2025
58 of 60 checks passed
@cdcme cdcme deleted the fix-32247-update-table-used-for-cert-based-auth branch November 7, 2025 19:28
cdcme added a commit that referenced this pull request Nov 7, 2025
Implements #32247. This is the complete feature branch, consolidating:

- #35018
- #34758
- #35009
- #35181
- #35342

---------

Co-authored-by: Jonathan Katz <44128041+jkatz01@users.noreply.github.com>
Co-authored-by: RachelElysia <71795832+RachelElysia@users.noreply.github.com>
Co-authored-by: Martin Angers <martin.n.angers@gmail.com>
Co-authored-by: jkatz01 <yehonatankatz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants